Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only create a single Managed_Resource for the response stream in HTTP.request #12405

Merged
merged 4 commits into from
Mar 4, 2025

Conversation

GregoryTravis
Copy link
Contributor

@GregoryTravis GregoryTravis commented Mar 3, 2025

Previously, Response would create a Response_Body from an HTTP response Java stream on-demand, which meant that certain call patterns would create multiple Input_Streams from the same Java InputStream.

With this change, an Input_Stream is created immediately and only one time.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@GregoryTravis GregoryTravis added the CI: No changelog needed Do not require a changelog entry for this PR. label Mar 3, 2025
@GregoryTravis GregoryTravis marked this pull request as ready for review March 3, 2025 21:13
@GregoryTravis GregoryTravis added the CI: Ready to merge This PR is eligible for automatic merge label Mar 4, 2025
@mergify mergify bot merged commit bc7d33d into develop Mar 4, 2025
65 of 66 checks passed
@mergify mergify bot deleted the wip/gmt/12291-one-mr branch March 4, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants